fix(weave): include scores from scorers with illegal characters in name #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=b8ccd62ef681dc067c04f47a0c2886df00b5443d |
gtarpenning
commented
Oct 17, 2024
...ePanelComponents/Home/Browse3/pages/wfReactInterface/tsDataModelHooksEvaluationComparison.ts
Outdated
Show resolved
Hide resolved
gtarpenning
commented
Oct 17, 2024
weave/flow/scorer.py
Outdated
Comment on lines
107
to
108
| if not scorer_name: | ||
| raise ValueError("Scorer name is required") |
There was a problem hiding this comment.
required by lint for some reason, should be impossible
gtarpenning
changed the title
gtarpenning
changed the title
tssweeney
approved these changes
Oct 17, 2024
gtarpenning
force-pushed
the
griffin/eval-fix-name-metrics
branch
from
8e5cabd to
fb44f46
Compare
gtarpenning
commented
Oct 30, 2024
|
|
||
| @pytest.mark.parametrize( | ||
| "scorer_name", | ||
| ["my scorer", "my-scorer()*&^%$@#/", "my-scorer", " my scorer "], |
There was a problem hiding this comment.
these names should all end up being the same @andrewtruong
|
|
||
| if scorer_name: | ||
| scorer_name = sanitize_object_name(scorer_name) | ||
|
|
||
| return (scorer_name, score_fn, summarize_fn) # type: ignore |
There was a problem hiding this comment.
oh I see, you need to do this because we return scorer_name here but sanitization currently happens at saving step
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr includes:
Note: Scorers with names like
v1andv1!will be treated as identical...Master:
This branch:
This is the UI for the above two runs, while the unsanitized scorers look different, we can still compare them in the UI.
Testing
Added test