Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): don't show focus outline on calls grid #2763

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

jamie-rasmussen
Copy link
Collaborator

Description

@harukatab noticed that if you click the empty space at the left bottom of the calls table and click arrow key up and down you get a focus outline that doesn't look very good.

Before:

Screenshot 2024-10-23 at 1 13 48 PM

Testing

How was this PR tested?

@jamie-rasmussen jamie-rasmussen requested review from a team as code owners October 23, 2024 18:15
@jamie-rasmussen jamie-rasmussen changed the title chore: don't show focus outline on calls grid chore(ui): don't show focus outline on calls grid Oct 23, 2024
Copy link
Contributor

@harukatab harukatab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any approval power but this fixed it! Putting screenshot

Screen.Recording.2024-10-23.at.11.20.55.AM.mov

@circle-job-mirror
Copy link

@jamie-rasmussen jamie-rasmussen merged commit 6f3094f into master Oct 24, 2024
104 of 105 checks passed
@jamie-rasmussen jamie-rasmussen deleted the jamie/calls-table-focus branch October 24, 2024 16:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants