Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: LLM Judge - Hackweek 2 #2771

Closed
wants to merge 36 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
65f71ad
ok, basic implementation
tssweeney Oct 24, 2024
9cb0a7f
lint
tssweeney Oct 24, 2024
0cb8f4c
init
tssweeney Oct 24, 2024
8ac2f9b
init
tssweeney Oct 24, 2024
74e6f9b
init
tssweeney Oct 24, 2024
9019bfe
init
tssweeney Oct 24, 2024
dd5e6e0
init
tssweeney Oct 24, 2024
8deb677
init
tssweeney Oct 24, 2024
eb66dc0
init
tssweeney Oct 24, 2024
4edf0d8
init
tssweeney Oct 24, 2024
84e5ed6
lint and small touches
tssweeney Oct 24, 2024
9e62bd1
lint all the things
tssweeney Oct 24, 2024
2da0073
Cursor: 1, Tim -1
tssweeney Oct 24, 2024
9e4f14a
Cursor: 1, Tim -1
tssweeney Oct 24, 2024
9eb0092
Cursor: 1, Tim 0
tssweeney Oct 24, 2024
43836a7
Cursor: 1, Tim 0
tssweeney Oct 24, 2024
029d301
Cursor: 1, Tim 1
tssweeney Oct 24, 2024
164030f
Cursor: 1, Tim 2
tssweeney Oct 24, 2024
d77f070
Some better links
tssweeney Oct 24, 2024
0407fdd
Lint
tssweeney Oct 24, 2024
f1b1af7
Cursor: 100
tssweeney Oct 24, 2024
191e04b
init
tssweeney Oct 24, 2024
a9e2681
merged
tssweeney Oct 24, 2024
0b91ec5
making progress
tssweeney Oct 24, 2024
a57e594
almost there
tssweeney Oct 24, 2024
136358c
almost there
tssweeney Oct 24, 2024
0e9eed1
ok, just one more thing
tssweeney Oct 24, 2024
9768cb0
Major milestone
tssweeney Oct 24, 2024
4bce2cc
init
tssweeney Oct 24, 2024
ca7ec99
init
tssweeney Oct 25, 2024
2c29a73
final bit before extras
tssweeney Oct 25, 2024
0685cbb
init
tssweeney Oct 25, 2024
83f0ccf
INITIAL REFACTOR TO MEET ADRIAN!
tssweeney Oct 25, 2024
f56b0d9
INITIAL REFACTOR TO MEET ADRIAN!
tssweeney Oct 25, 2024
d557af3
INITIAL REFACTOR TO MEET ADRIAN! - DOne
tssweeney Oct 25, 2024
7d1bf72
Added UI Feature Flag
tssweeney Oct 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 198 additions & 0 deletions tests/trace/demo.ipynb

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion weave-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@
"wavesurfer.js": "^2.0.0",
"web-tree-sitter": "^0.20.5",
"yet-another-react-lightbox": "^3.17.5",
"zen-observable": "^0.10.0"
"zen-observable": "^0.10.0",
"zod": "^3.23.8"
},
"devDependencies": {
"@babel/core": "^7.23.2",
Expand Down
19 changes: 16 additions & 3 deletions weave-js/src/components/FancyPage/useProjectSidebar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ import {IconNames} from '@wandb/weave/components/Icon';
import _ from 'lodash';
import {useMemo} from 'react';

import {
ENABLE_ONLINE_EVAL_UI,
getFeatureFlag,
} from '../PagePanelComponents/Home/Browse3/windowFlags';
import {FancyPageSidebarItem} from './FancyPageSidebar';

export const useProjectSidebar = (
Expand Down Expand Up @@ -31,6 +35,7 @@ export const useProjectSidebar = (
const isNoSidebarItems = !showModelsSidebarItems && !showWeaveSidebarItems;
const isBothSidebarItems = showModelsSidebarItems && showWeaveSidebarItems;
const isShowAll = isNoSidebarItems || isBothSidebarItems;
const enableOnlineEvalUI = getFeatureFlag(ENABLE_ONLINE_EVAL_UI);
return useMemo(() => {
const allItems = isLoading
? []
Expand Down Expand Up @@ -158,6 +163,13 @@ export const useProjectSidebar = (
isShown: showWeaveSidebarItems || isShowAll,
iconName: IconNames.Table,
},
{
type: 'button' as const,
name: 'Scorers',
slug: 'weave/scorers',
isShown: enableOnlineEvalUI && (showWeaveSidebarItems || isShowAll),
iconName: IconNames.TypeNumberAlt,
},
{
type: 'divider' as const,
key: 'dividerWithinWeave',
Expand Down Expand Up @@ -213,10 +225,11 @@ export const useProjectSidebar = (
return onlyShownItems;
}, [
isLoading,
isModelsOnly,
isWeaveOnly,
showWeaveSidebarItems,
isShowAll,
isWeaveOnly,
viewingRestricted,
isModelsOnly,
showWeaveSidebarItems,
enableOnlineEvalUI,
]);
};
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ export const SmallRef: FC<{
objRef: ObjectRef;
wfTable?: WFDBTableType;
iconOnly?: boolean;
}> = ({objRef, wfTable, iconOnly = false}) => {
nameOnly?: boolean;
}> = ({objRef, wfTable, iconOnly = false, nameOnly = false}) => {
const {
useObjectVersion,
useOpVersion,
Expand Down Expand Up @@ -140,7 +141,9 @@ export const SmallRef: FC<{
// TODO: Why is this necessary? The type is coming back as `objRef`
rootType = {type: 'OpDef'};
}
const {label} = objectRefDisplayName(objRef, versionIndex);
const {label} = nameOnly
? {label: objRef.artifactName}
: objectRefDisplayName(objRef, versionIndex);

const rootTypeName = getTypeName(rootType);
let icon: IconName = IconNames.CubeContainer;
Expand Down
17 changes: 16 additions & 1 deletion weave-js/src/components/PagePanelComponents/Home/Browse3.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,9 @@ import {
} from './Browse3/pages/ObjectVersionsPage';
import {OpPage} from './Browse3/pages/OpPage';
import {OpsPage} from './Browse3/pages/OpsPage';
import {OpVersionPage} from './Browse3/pages/OpVersionPage';
import {OpVersionPage} from './Browse3/pages/OpVersionPage/OpVersionPage';
import {OpVersionsPage} from './Browse3/pages/OpVersionsPage';
import {ScorersPage} from './Browse3/pages/ScorersPage/ScorersPage';
import {TablePage} from './Browse3/pages/TablePage';
import {TablesPage} from './Browse3/pages/TablesPage';
import {useURLSearchParamsDict} from './Browse3/pages/util';
Expand All @@ -100,6 +101,7 @@ import {
WFDataModelAutoProvider,
} from './Browse3/pages/wfReactInterface/context';
import {useHasTraceServerClientContext} from './Browse3/pages/wfReactInterface/traceServerClientContext';
import {ENABLE_ONLINE_EVAL_UI, getFeatureFlag} from './Browse3/windowFlags';
import {useDrawerResize} from './useDrawerResize';

LicenseInfo.setLicenseKey(
Expand Down Expand Up @@ -153,6 +155,7 @@ const tabOptions = [
'evaluations',
'boards',
'tables',
'scorers',
];
const tabs = tabOptions.join('|');
const browse3Paths = (projectRoot: string) => [
Expand Down Expand Up @@ -492,6 +495,9 @@ const Browse3ProjectRoot: FC<{
<Route path={`${projectRoot}/:tab(compare-evaluations)`}>
<CompareEvaluationsBinding />
</Route>
<Route path={`${projectRoot}/:tab(scorers)`}>
<ScorersPageBinding />
</Route>
{/* BOARDS */}
<Route
path={[
Expand Down Expand Up @@ -973,6 +979,15 @@ const CompareEvaluationsBinding = () => {
);
};

const ScorersPageBinding = () => {
const {entity, project} = useParamsDecoded<Browse3TabParams>();
const enableOnlineEvalUI = getFeatureFlag(ENABLE_ONLINE_EVAL_UI);
if (!enableOnlineEvalUI) {
return null;
}
return <ScorersPage entity={entity} project={project} />;
};

const OpsPageBinding = () => {
const params = useParamsDecoded<Browse3TabItemParams>();

Expand Down
Loading
Loading