chore(weave): Add back hook to check for weave data #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericakdiaz
commented
Oct 24, 2024
| project, | ||
| {}, | ||
| 1, | ||
| true, |
There was a problem hiding this comment.
added metadata_only param
tssweeney
reviewed
Oct 24, 2024
| } | ||
| ); | ||
|
|
||
| const calls = tsWFDataModelHooks.useCalls( |
There was a problem hiding this comment.
you could optimize this by selecting only the id column for example as well
tssweeney
approved these changes
Oct 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This basically reverts the cleanup from #2132. I believe that the limit issue should've been fixed in #2420, so hopefully we should be able to check if a project has weave data more quickly.
Testing
How was this PR tested?
This should have no effect since it's unused, will follow up in core with a change similar to this https://github.com/wandb/core/pull/20661/commits/3ca824472beff5023cd0c4926e1f95d9cbc63f1c and see how the performance is now.