feat(weave): Team Friday Ship: Online Evals Integration Branch: Weave #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 75a430b.
…tuff, which is cool.
…e' of github.com:wandb/weave into team_friday_ship/online_evals_hackweek_integration_weave
tssweeney
commented
Oct 28, 2024
| collectionName: C, | ||
| req: TraceObjCreateReq<T> | ||
| ) => { | ||
| const knownCollection = collectionRegistry[collectionName]; |
There was a problem hiding this comment.
TODO: remember to sanitize the name!
tssweeney
commented
Oct 29, 2024
| action_type: Literal["builtin"] = "builtin" | ||
| name: str | ||
|
|
||
| class ConfiguredContainsWordsAction(BaseModel): |
There was a problem hiding this comment.
Are these just for demo or intended to actually land?
tssweeney
changed the title
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combination of
Pairs with https://github.com/wandb/core/pull/25146