feat(ui): navigate up/down on the calls page from the peek drawer #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=c60b0b63ebc6507d283a486bf9a68620db6e0b02 |
tssweeney
reviewed
Oct 31, 2024
|
|
||
| const getNextRowId = useCallback( | ||
| (currentId: string) => { | ||
| console.log('getNextRowId', currentId, rowIds); |
tssweeney
reviewed
Oct 31, 2024
| @@ -479,6 +481,15 @@ export const CallsTable: FC<{ | |||
| } | |||
| } | |||
| }, [rowIds, peekId]); | |||
| const {setRowIds} = useContext(TableRowSelectionContext); | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
i would use const {isPeeking} = useContext(WeaveflowPeekContext); instead
There was a problem hiding this comment.
which returns true if the component is inside a peek drawer
tssweeney
reviewed
Oct 31, 2024
| active={showTraceTree ?? false} | ||
| onClick={onToggleTraceTree} | ||
| /> | ||
| <Box |
There was a problem hiding this comment.
seems like these should only be present if it is peaking AND there are row ids set in the context. I think these arrows will show up on the primary call page right now
There was a problem hiding this comment.
This flex-box puts the tree expansion to the left when full screen (since space-between) will left justify if there is a single element.
tssweeney
approved these changes
Nov 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WB-21663
use
shift+up arroworshift+down arrowto control the selected call in the calls table.implementation can be extended to the other main page tables, although the rowIds behave slightly differently.
Testing
How was this PR tested?