fix(ui): Sorted aggregated columns no longer crash tables during ungrouping #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=19e20672e52a6423c620367e3ab138fe433ad975 |
nicholaspun-wandb
force-pushed
the
nicholaspun-wb-16067
branch
from
1dd789c to
ef94235
Compare
nicholaspun-wandb
changed the title
domphan-wandb
approved these changes
Oct 29, 2024
jwlee64
approved these changes
Oct 30, 2024
nicholaspun-wandb
force-pushed
the
nicholaspun-wb-16067
branch
from
ef94235 to
3121586
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: WB-16067
Description
Testing
Old behaviour:
Screen.Recording.2024-10-28.at.3.28.24.PM.mov
New behaviour:
Screen.Recording.2024-10-28.at.3.30.42.PM.mov
Existing behaviour when no sorting is applied (the fix aligns with the existing behaviour):
Screen.Recording.2024-10-28.at.3.32.03.PM.mov