Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weave_query): Add string op to parse number with thousands and decimal separators #2864

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

nicholaspun-wandb
Copy link
Contributor

@nicholaspun-wandb nicholaspun-wandb commented Nov 5, 2024

Description

  • Handles WB-16442
  • Creates a new string op that will parse numbers with a thousands separator.

Testing

Added unit tests

@nicholaspun-wandb nicholaspun-wandb self-assigned this Nov 5, 2024
@nicholaspun-wandb nicholaspun-wandb changed the title feat(weave_query) Add string op to convert numbers with locale feat(weave_query): Add string op to convert numbers with locale Nov 5, 2024
@circle-job-mirror
Copy link

circle-job-mirror bot commented Nov 5, 2024

@nicholaspun-wandb nicholaspun-wandb marked this pull request as ready for review November 6, 2024 18:54
@nicholaspun-wandb nicholaspun-wandb requested a review from a team as a code owner November 6, 2024 18:54
@nicholaspun-wandb nicholaspun-wandb changed the title feat(weave_query): Add string op to convert numbers with locale feat(weave_query): Add string op to parse number with a specified thousands separator Nov 6, 2024
@domphan-wandb
Copy link
Contributor

I think this solution is pretty sweet especially since you removed the locale calls. Do you think it would feasible to add a second optional argument to represent the decimal symbol if needed? For example, I think 1.234.567,14 is valid in many European countries.

@nicholaspun-wandb nicholaspun-wandb changed the title feat(weave_query): Add string op to parse number with a specified thousands separator feat(weave_query): Add string op to parse number with thousands and decimal separators Nov 6, 2024
@nicholaspun-wandb nicholaspun-wandb merged commit 71128de into master Nov 8, 2024
116 checks passed
@nicholaspun-wandb nicholaspun-wandb deleted the npun-wb-16442 branch November 8, 2024 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants