Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weave): Make Weave* objects deepcopy-able #2868

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Nov 5, 2024

Description

Makes Weave* objects deepcopy-able by implementing __deepcopy__. These were previously not deepcopy-able because Weave* objects have a server that contains a lock.

Related Issues:
#2830

Testing

  1. Unit tests; and
  2. Manual testing for broken LiteLLM stuff
    image
    image

@circle-job-mirror
Copy link

circle-job-mirror bot commented Nov 5, 2024

@andrewtruong andrewtruong marked this pull request as ready for review November 5, 2024 10:25
@andrewtruong andrewtruong requested a review from a team as a code owner November 5, 2024 10:25
@andrewtruong andrewtruong merged commit c376b31 into master Nov 5, 2024
119 checks passed
@andrewtruong andrewtruong deleted the andrew/deepcopy branch November 5, 2024 19:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants