Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(weave): ruff: enable TRY004 #2903

Merged
merged 4 commits into from
Nov 6, 2024
Merged

chore(weave): ruff: enable TRY004 #2903

merged 4 commits into from
Nov 6, 2024

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Nov 6, 2024 •
edited
Loading

@circle-job-mirror
Copy link

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=7582b523844548b978a00179135be98fd7039d27

@andrewtruong andrewtruong marked this pull request as ready for review November 6, 2024 04:10
@andrewtruong andrewtruong requested a review from a team as a code owner November 6, 2024 04:10
@andrewtruong andrewtruong changed the base branch from master to andrew/try1 November 6, 2024 04:29
gtarpenning
gtarpenning approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@gtarpenning gtarpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, i like it

Base automatically changed from andrew/try1 to master November 6, 2024 17:25
@andrewtruong andrewtruong merged commit 564f61d into master Nov 6, 2024
116 checks passed
@andrewtruong andrewtruong deleted the andrew/try2 branch November 6, 2024 18:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gtarpenning gtarpenning gtarpenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewtruong @gtarpenning