chore(weave): Rename ActionDefintion to ActionSpec to match naming patterns #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tssweeney
commented
Nov 8, 2024
| class ActionDefinition(base_object_def.BaseObject): | ||
| spec: ActionSpecType = Field(..., discriminator="action_type") | ||
| class ActionSpec(base_object_def.BaseObject): | ||
| config: ActionConfigType = Field(..., discriminator="action_type") |
There was a problem hiding this comment.
Changed the nested property to config so that we don't have a nested "spec". This also matches the parameters in the dispatcher
gtarpenning
approved these changes
Nov 8, 2024
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=114084c2b5de44b07e5864403cea779a2cabd283 |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=a999ef19bf85c49c29e328fa1cca56470b584dc1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our only chance to change this (before it ships). Let's get it right