Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): ignore parent when nonexistent in trace tree view #2945

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Nov 8, 2024

Description

WB-21791

When generating the trace tree structure, remove reference to parentID if it doesn't exist. Also update type in the render component just in case so we never error.

Prod:
Screenshot 2024-11-08 at 10 31 49 AM

This branch:
Screenshot 2024-11-08 at 10 30 22 AM

@gtarpenning gtarpenning changed the title Griffin/trace tree null parent hack fix(ui): ignore parent when nonexistent in trace tree view Nov 8, 2024
@gtarpenning gtarpenning marked this pull request as ready for review November 8, 2024 18:35
@gtarpenning gtarpenning requested review from a team as code owners November 8, 2024 18:35
@gtarpenning gtarpenning enabled auto-merge (squash) November 8, 2024 18:38
@circle-job-mirror
Copy link

@gtarpenning gtarpenning merged commit fef544f into master Nov 8, 2024
113 of 115 checks passed
@gtarpenning gtarpenning deleted the griffin/trace-tree-null-parent-hack branch November 8, 2024 18:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants