-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(weave): human annotation labeling review comments #3020
Conversation
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=2e92f00c4b9d0bbedf3b021776e6922954dde37a |
case 'integer': | ||
return ( | ||
<NumericalFeedbackColumn | ||
min={jsonSchema.minimum} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure your are respecting https://json-schema.org/understanding-json-schema/reference/numeric#range correctly (inclusive vs non inclusive)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it should be inclusive by default, which is what the component expects. Rejecting iff: (min != null && parsedVal < min) || (max != null && parsedVal > max)
so accepting when val == min
Description
Crush a bunch of human feedback rough edges.
This pr:
Sidebar:
Trace table:
hide/show feedback sidebar
->hide/show feedback
Create form:
min/max
->minimum/maximum