fix(weave): Elide display names that exceed the char limit #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewtruong
commented
Nov 21, 2024
| @@ -8,6 +8,33 @@ | |||
| from threading import Thread as _Thread | |||
| from typing import Any, Callable | |||
|
|
|||
| LOG_ONCE_MESSAGE_SUFFIX = " (subsequent messages of this type will be suppressed)" | |||
There was a problem hiding this comment.
This code is moved from op_extensions/log_once.py so it's more accessible
andrewtruong
commented
Nov 21, 2024
| from weave.trace.refs import ObjectRef | ||
| from weave.trace.util import log_once |
There was a problem hiding this comment.
see comment below
andrewtruong
commented
Nov 21, 2024
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| from weave.trace.context.tests_context import get_raise_on_captured_errors | |||
| from weave.trace.op import FinishCallbackType, Op | |||
| from weave.trace.op_extensions.log_once import log_once | |||
| from weave.trace.util import log_once | |||
There was a problem hiding this comment.
see comment below
andrewtruong
commented
Nov 21, 2024
| @@ -41,9 +42,9 @@ | |||
| from weave.trace.serializer import get_serializer_for_obj | |||
| from weave.trace.settings import client_parallelism | |||
| from weave.trace.table import Table | |||
| from weave.trace.util import deprecated | |||
| from weave.trace.util import deprecated, log_once | |||
There was a problem hiding this comment.
see comment below
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=966ea5d7c322c9aa0fd3744bfdb43f93e287473a |
andrewtruong
commented
Nov 21, 2024
Comment on lines
+205
to
+214
| @property | ||
| def display_name(self) -> str | Callable[[Call], str] | None: | ||
| return self._display_name | ||
|
|
||
| @display_name.setter | ||
| def display_name(self, name: str | Callable[[Call], str] | None) -> None: | ||
| if isinstance(name, str): | ||
| name = elide_display_name(name) | ||
| self._display_name = name | ||
|
|
There was a problem hiding this comment.
this is kinda ugly, but it will ensure the display_name is always correct
tssweeney
approved these changes
Nov 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR elides all call
display_nameto be at most the max char limit.Internal thread:
https://weightsandbiases.slack.com/archives/C01T8BLDHKP/p1732213159962419?thread_ts=1732208270.722299&cid=C01T8BLDHKP