chore(weave): Wrap up loose ends with Annotations #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=64b6f6a0f54fd358a645c91da68089ada39da9cd |
gtarpenning
approved these changes
Nov 25, 2024
|
|
||
| # Handle Pydantic model | ||
| if isinstance(field_schema, type) and issubclass(field_schema, BaseModel): | ||
| data["field_schema"] = field_schema.model_json_schema() # type: ignore |
There was a problem hiding this comment.
We currently don't support nested objects, we might want to throw with an actionable error mentioning they will have to create multiple specs. I will add a ticket to move as much of the human feedback UI to the Zod form, which will allow for nested.
There was a problem hiding this comment.
I think we should allow the creation, but maybe in the UI there is a fallback that allows free-form json input or something
Comment on lines
+77
to
+85
| """ | ||
| Validates a payload against this annotation spec's schema. | ||
|
|
||
| Args: | ||
| payload: The data to validate against the schema | ||
|
|
||
| Returns: | ||
| bool: True if validation succeeds, False otherwise | ||
| """ |
There was a problem hiding this comment.
I think including the work "feedback" or in some way tying it to the feedback schema might make sense here, perhaps an example
shawnlewis
approved these changes
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_schematofield_schemaOther followup notes for Griffin: