Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): add back costs to call summary page #3094

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

gtarpenning
Copy link
Member

Description

Uses costs from trace tree to render the callSummary costs.

Testing

Prod:
Screenshot 2024-11-26 at 12 16 27 PM

Branch:
Screenshot 2024-11-26 at 12 16 03 PM

@gtarpenning gtarpenning marked this pull request as ready for review November 26, 2024 20:16
@gtarpenning gtarpenning requested review from a team as code owners November 26, 2024 20:16
@gtarpenning gtarpenning changed the title Griffin/trace tree perf fix chore(ui): add back costs to call summary page Nov 26, 2024
@gtarpenning gtarpenning requested a review from jwlee64 November 26, 2024 20:19
@circle-job-mirror
Copy link

circle-job-mirror bot commented Nov 26, 2024

Copy link
Contributor

@jwlee64 jwlee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyty for tracking thisdown

@gtarpenning gtarpenning enabled auto-merge (squash) November 26, 2024 22:04
@gtarpenning gtarpenning merged commit 37ac7d9 into master Nov 26, 2024
120 checks passed
@gtarpenning gtarpenning deleted the griffin/trace-tree-perf-fix branch November 26, 2024 22:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants