chore(weave): load model default properly #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=b483c14f1538019bdf14dbaa88cee8aed681d17b |
gtarpenning
reviewed
Nov 26, 2024
| @@ -121,3 +121,68 @@ export const LLM_MAX_TOKENS = { | |||
| }; | |||
|
|
|||
| export type LLMMaxTokensKey = keyof typeof LLM_MAX_TOKENS; | |||
|
|
|||
| export const LLM_MAX_TOKENS_KEYS: LLMMaxTokensKey[] = Object.keys( | |||
There was a problem hiding this comment.
Suggested change
| export const LLM_MAX_TOKENS_KEYS: LLMMaxTokensKey[] = Object.keys( | |
| export const LLM_MAX_TOKENS_KEYS = Object.keys( |
| ) as LLMMaxTokensKey[]; | ||
|
|
||
| // Helper function to calculate string similarity using Levenshtein distance | ||
| const getLevenshteinDistance = (str1: string, str2: string): number => { |
There was a problem hiding this comment.
I think we are using js-levenshtein in the app, can you use that?
| LLM_MAX_TOKENS_KEYS | ||
| ); | ||
| toast( | ||
| `We currently don't support ${inputs.model}, in the playground. We will default to ${closestModel}` |
There was a problem hiding this comment.
do we always want to default to the most similar model? can it ever be a typo? I would expect this case to most likely happen with custom models, which they might not want to have auto-selected.
|
@gtarpenning down to remove the smart default to just load the model in if it exist and if not go with the default model |
gtarpenning
approved these changes
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
before the model was not loaded into the settings, when opening a trace in playground
adds a smart default, if the model is not one of the models we support