Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): rearrange nav #3103

Merged
merged 2 commits into from
Nov 27, 2024
Merged

chore(ui): rearrange nav #3103

merged 2 commits into from
Nov 27, 2024

Conversation

jamie-rasmussen
Copy link
Collaborator

@jamie-rasmussen jamie-rasmussen commented Nov 27, 2024

Description

Rearrange navbar to account for several Weave buttons (prompts, scorers, leaders, playground) having been added, causing trouble with Intercom button.

Internal Slack:
https://weightsandbiases.slack.com/archives/C01T8BLDHKP/p1732660859482469
https://weightsandbiases.slack.com/archives/CA4PBB2TF/p1732492325984729

Internal Figma:
https://www.figma.com/design/27JVuBYWHbcAYc8WPb4HqA/Weaveflow-hifi?node-id=3305-27224&t=GsfniY2XFbZOUwn4-1

Note: Per Adam holding off on Overview -> Settings name change because we need to also think about URL, breadcrumbs, etc.

Testing

How was this PR tested?

@jamie-rasmussen jamie-rasmussen force-pushed the jamie/sidebar-update branch 2 times, most recently from ef66174 to 654a059 Compare November 27, 2024 15:52
@circle-job-mirror
Copy link

circle-job-mirror bot commented Nov 27, 2024

@jamie-rasmussen jamie-rasmussen marked this pull request as ready for review November 27, 2024 20:19
@jamie-rasmussen jamie-rasmussen requested review from a team as code owners November 27, 2024 20:19
Copy link
Contributor

@jwlee64 jwlee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jamie-rasmussen jamie-rasmussen merged commit 8950d3b into master Nov 27, 2024
121 checks passed
@jamie-rasmussen jamie-rasmussen deleted the jamie/sidebar-update branch November 27, 2024 21:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants