fix(ui): better defaults for trace/eval trace tree #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtarpenning
commented
Nov 27, 2024
| @@ -237,6 +239,7 @@ function buildCallsTableColumns( | |||
| fullWidth={true} | |||
| preservePath={preservePath} | |||
| color={TEAL_600} | |||
| isEval={isEval} | |||
There was a problem hiding this comment.
necessary change because the opName passed into callLink can be displayName
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=c2890d1cf5574940f1f099365217ee320a366e74 |
jamie-rasmussen
approved these changes
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While adding support for maintaining show-annotation state, I broke the trace tree defaults. Specifically we want to be able to show or hide the trace tree when the user sets it, but default to showing when a trace is normal, or hiding when the trace is an evaluation.
Testing