Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): Better error message for scorer signature validation #3115

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Dec 2, 2024

Clarifies the error and provides clear action for user to resolve

Resolves: https://wandb.atlassian.net/browse/WB-22317

@circle-job-mirror
Copy link

circle-job-mirror bot commented Dec 2, 2024

@andrewtruong andrewtruong marked this pull request as ready for review December 3, 2024 20:58
@andrewtruong andrewtruong requested a review from a team as a code owner December 3, 2024 20:58
weave/scorers/base_scorer.py Outdated Show resolved Hide resolved
weave/scorers/base_scorer.py Outdated Show resolved Hide resolved
@andrewtruong andrewtruong enabled auto-merge (squash) December 6, 2024 03:07
@andrewtruong andrewtruong merged commit 32fc0da into master Dec 12, 2024
121 checks passed
@andrewtruong andrewtruong deleted the andrew/better-error-msg branch December 12, 2024 19:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants