Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): emojis looking bad in night mode #3118

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jamie-rasmussen
Copy link
Collaborator

Description

While watching GA release video I saw that emojis in places were getting incorrectly inverted by night mode.
https://www.youtube.com/watch?v=IQcGGNLN3zo&t=113s

Before:
Screenshot 2024-12-02 at 1 42 30 PM

After:
Screenshot 2024-12-02 at 1 42 16 PM

Testing

How was this PR tested?

@jamie-rasmussen jamie-rasmussen requested review from a team as code owners December 2, 2024 19:45
@circle-job-mirror
Copy link

@circle-job-mirror
Copy link

Copy link
Contributor

@jwlee64 jwlee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more scary chicken

@jamie-rasmussen jamie-rasmussen merged commit fcd3ea2 into master Dec 2, 2024
119 of 120 checks passed
@jamie-rasmussen jamie-rasmussen deleted the jamie/emoji-night-fixes branch December 2, 2024 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants