feat(weave): Add option to name weave evals (and give a memorable name if not specified) #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewtruong
changed the title
andrewtruong
force-pushed
the
andrew/named-eval
branch
from
e9441a5 to
b3df39c
Compare
jamie-rasmussen
approved these changes
Dec 6, 2024
weave/trace/op.py
Outdated
| or param.default is MISTRAL_NOT_GIVEN | ||
| or param.default is CEREBRAS_NOT_GIVEN | ||
| or param.default is Ellipsis | ||
| return param.default in ( |
There was a problem hiding this comment.
Bunch of this is from your other PR
weave/flow/util.py
Outdated
|
|
||
| def make_memorable_name() -> str: | ||
| adjectives = [ | ||
| "jubilant", |
There was a problem hiding this comment.
Doesn't really matter but I'd alphabetize
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to expose "op naming" to
Evaluations. Users can specify a custom name for evaluations, or we will generate one by default.Resolves: https://wandb.atlassian.net/browse/WB-22238