chore(weave): unhide completion iterations #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=f9649dd63d8f24543416a6e6f8ff1f5b1b561490 |
jwlee64
commented
Dec 3, 2024
| } | ||
| /> | ||
|
|
||
| {/* TODO: N times to run is not supported for all models */} |
There was a problem hiding this comment.
the only new thing, everything else if just rearranging
gtarpenning
reviewed
Dec 3, 2024
| } | ||
| label="Temperature" | ||
| value={playgroundState.temperature} | ||
| label="Completion iterations" |
There was a problem hiding this comment.
Can we add a tooltip? I'm not the target audience but I don't really know what this means... Where are the multiple iterations going to end up?
gtarpenning
approved these changes
Dec 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show completion iterations in Playground settings
Rearranged the settings menu a little to be more in line with designs
before
After
Testing
How was this PR tested?