Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): update db to use replicated tables #3148

Merged
merged 19 commits into from
Dec 11, 2024

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Dec 4, 2024

Description

To maintain the ability to run on simpler clickhouse installs without replication (especially nice for testing) , the migration script will be modified to apply these modifications dynamically.

To test this, modified sql with this:

find . -type f -name \*.sql | xargs gsed -z -i -r 's/ENGINE = (\S*)MergeTree([^\n]*)/ENGINE = Replicated\1MergeTree\2/g'

Requires this PR (after this weave pr is merged):

Done:

Testing

Testing with:

  • pytest
  • qa
  • managed instances (clickhouse.cloud)
  • on prem test cluster

@circle-job-mirror
Copy link

circle-job-mirror bot commented Dec 4, 2024

@raubitsj raubitsj marked this pull request as ready for review December 11, 2024 18:16
@raubitsj raubitsj requested a review from a team as a code owner December 11, 2024 18:16
@raubitsj raubitsj merged commit af81503 into master Dec 11, 2024
112 checks passed
@raubitsj raubitsj deleted the jhr/onprem-clickhouse-1 branch December 11, 2024 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants