Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): break an import cycle #3155

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

jamie-rasmussen
Copy link
Collaborator

Description

Pure refactor, breaking some import cycles that cause reloading problem in development.

Before:

npx madge --circular  /Users/jamie/source/wandb/core/services/weave-python/weave-public/weave-js/src/components/PagePanelComponents/Home/Browse3.tsx  | grep Browse3.t

✖ Found 142 circular dependencies!

139) Browse3.tsx > Browse3/pages/CallPage/CallPage.tsx
141) Browse3.tsx > Browse3/pages/CallPage/CallPage.tsx > Browse3/pages/CallPage/CallDetails.tsx > Browse3/pages/CallsPage/CallsTable.tsx
142) Browse3.tsx > Browse3/pages/CallPage/CallPage.tsx > Browse3/pages/CallPage/PaginationControls.tsx

After:

npx madge --circular  /Users/jamie/source/wandb/core/services/weave-python/weave-public/weave-js/src/components/PagePanelComponents/Home/Browse3.tsx  | grep Browse3.t
✖ Found 139 circular dependencies!

Testing

How was this PR tested?

@circle-job-mirror
Copy link

@jamie-rasmussen jamie-rasmussen marked this pull request as ready for review December 6, 2024 03:36
@jamie-rasmussen jamie-rasmussen requested review from a team as code owners December 6, 2024 03:36
Copy link
Member

@gtarpenning gtarpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thats definitely what I should have done from the beginning. Thanks!

@jamie-rasmussen jamie-rasmussen merged commit 43ab785 into master Dec 6, 2024
120 checks passed
@jamie-rasmussen jamie-rasmussen deleted the jamie/break-cycle branch December 6, 2024 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants