-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): render bounding boxes on media panel without points #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g box when point cloud empty
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
brianlund-wandb
changed the title
WB-16623 coercing empty point to default, targeting camera on bounding box when point cloud empty
fix: WB-16623 empty media panel
Dec 5, 2024
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=8efbfb217c0ad62ebe0a36621735f68d72f5ee05 |
I have read the CLA Document and I hereby sign the CLA |
brianlund-wandb
changed the title
fix: WB-16623 empty media panel
fix(app): render bounding boxes on media panel without points
Dec 6, 2024
nhusher
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems reasonable to me
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When logging a point cloud via
wandb.Object3D
with an empty list of points we still end up including a single, empty point in the file we use to generate the panel.The library we use to generate the panel, Babylon, fails to interpret that point, and generates a confusing panel.
The fix
[0, 0, 0]
Testing
Reproduction steps are included in the ticket. The fix was tested locally, and includes a unit test for the coercion logic.