chore(weave): add with_new_client context for concurrent ch queries #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 6, 2024
gtarpenning
changed the title
gtarpenning
force-pushed
the
12-06-chore_weave_add_dynamic_batch_processor_for_call_stream_batching
branch
from
8c91d2d to
9d77e3e
Compare
gtarpenning
force-pushed
the
12-06-chore_weave_add_secondary_client_context_for_concurrent_ch_querying
branch
from
2893ecb to
c324413
Compare
tssweeney
reviewed
Dec 6, 2024
gtarpenning
force-pushed
the
12-06-chore_weave_add_secondary_client_context_for_concurrent_ch_querying
branch
from
5c65027 to
ca4a8cb
Compare
gtarpenning
changed the title
Base automatically changed from
12-06-chore_weave_add_dynamic_batch_processor_for_call_stream_batching
to
master
December 6, 2024 21:46
…text_for_concurrent_ch_querying
tssweeney
approved these changes
Dec 6, 2024
gtarpenning
deleted the
12-06-chore_weave_add_secondary_client_context_for_concurrent_ch_querying
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a
with_new_clientcontext that returns a new ch client to handle concurrent database operations.Added a context manager
with_new_client()to temporarily switch to the secondary client for specific operations. Separate clients maintain separate session IDs, which should prevent theSESSION_LOCKEDerror.Testing