Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): ui op selecter jump back to top fix #3174

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Dec 6, 2024

Description

WB-22059

This pr:

  • refactors the OpSelector to its own component
  • wraps relevant functions in callbacks to prevent re-renders

There is still a bit of lag as the call table renders, but unless we lock the dropdown while MUI renders i'm not sure if there is an easy fix.

Testing

Can no longer reproduce the jumping to top behavior

@circle-job-mirror
Copy link

circle-job-mirror bot commented Dec 6, 2024

@gtarpenning gtarpenning marked this pull request as ready for review December 6, 2024 23:24
@gtarpenning gtarpenning requested review from a team as code owners December 6, 2024 23:24
@gtarpenning gtarpenning merged commit 059f388 into master Dec 7, 2024
120 checks passed
@gtarpenning gtarpenning deleted the griffin/op-filter-reset branch December 7, 2024 00:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants