chore(weave): Add generic iterator for trace server API objects #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=866809f160cbd70d99376ec19a324f2039b9312a |
andrewtruong
commented
Dec 9, 2024
| TransformFunc = Callable[[T], R] | ||
|
|
||
|
|
||
| class PaginatedIterator(Generic[T, R]): |
There was a problem hiding this comment.
This is basically a parameterized version of CallsIter
andrewtruong
commented
Dec 10, 2024
| ) | ||
| return response.calls | ||
|
|
||
| # TODO: Should be Call, not WeaveObject |
There was a problem hiding this comment.
This may need to be done later. Today, we wrap the "Call" in WeaveObject to give it nice "getting" properties, but the ideal state is to just have all of the functionality on Call itself. That change is outside the scope of this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purely a refactor to make the
CallsIterobject more generic. This will be used in a subsequent PR to implement something like "ObjectsIter"