Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Create scorer drawer style + small annotation drawer style tweaks #3186

Merged
merged 12 commits into from
Dec 12, 2024

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Dec 10, 2024

Description

https://wandb.atlassian.net/browse/WB-22274

This pr:

  • Does another pass on annotation design tweaks, fixing small spacing issues.
  • Better handles Create Scorer form state, when closing the drawer all fields are reset to default.
  • Fixes a bug in the Zod array element where when specifying a # of minimum elements the form would not correctly display an empty field. This was due to an upstream state issue, we were not listening for config updates, and thus adding an empty element to the array did not cause re-render.
  • Add border and change spacing around Zod array element to conform with design spec, and add + icon to button

Testing

More zod form tweaks: better padding, bigger title and buttons, add border around enum section
Screenshot 2024-12-10 at 2 38 06 PM

@circle-job-mirror
Copy link

@gtarpenning gtarpenning changed the title Griffin/more annotation feedback design chore(ui): Create scorer drawer style tweaks Dec 10, 2024
@gtarpenning gtarpenning changed the title chore(ui): Create scorer drawer style tweaks chore(ui): Create scorer drawer style + small annotation drawer style tweaks Dec 10, 2024
@gtarpenning gtarpenning marked this pull request as ready for review December 10, 2024 22:50
@gtarpenning gtarpenning requested review from a team as code owners December 10, 2024 22:50
@gtarpenning gtarpenning merged commit 96d1d0d into master Dec 12, 2024
119 of 120 checks passed
@gtarpenning gtarpenning deleted the griffin/more-annotation-feedback-design branch December 12, 2024 01:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants