style(weave): add icons to trace tree #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=634c3dc5b1e2134a74d936cfc39e3089b76b90f1 |
m-rgba
reviewed
Dec 13, 2024
jamie-rasmussen
approved these changes
Dec 13, 2024
| <span>•</span> | ||
| </> | ||
| <Tooltip | ||
| content="Finish Reason" |
There was a problem hiding this comment.
Prefer sentence case
| <Tooltip | ||
| content="Finish Reason" | ||
| trigger={ | ||
| <span> |
There was a problem hiding this comment.
I think a Pill renders a div, so this should probably be a block level element like div too.
| icon="checkmark-circle" | ||
| label={(call.output as any).choices[0].finish_reason} | ||
| color="moon" | ||
| className="-ml-[8px] bg-transparent text-moon-500 dark:bg-transparent dark:text-moon-500" |
There was a problem hiding this comment.
I didn't know you could write the negative margin that way in Tailwind, I think I've always done it ml-[-8px]. Interesting!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think this is what we want, mostly copied from @m-rgba pr here
https://github.com/wandb/weave/pull/3218/files#diff-fd135f6c043e8503d22da884b0464e16851a3364b605c6e95894c93aec355fcb
Testing
How was this PR tested?