style(weave): LLM dropdown UX improvements #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=fed2672d65ba41da176067a526bfcf73d5ecfcf8 |
gtarpenning
approved these changes
Dec 17, 2024
| acc.push({ | ||
| group: provider, | ||
| label: | ||
| llm.includes(provider) || provider === 'openai' |
There was a problem hiding this comment.
TIOLI: i'm becoming a simp for micro functions, could be a nice place for one that explains why we do this logic
There was a problem hiding this comment.
like:
function _make_dropdown_label(provider: string): string {
| @@ -397,8 +397,8 @@ export const LLM_PROVIDER_LABELS: Record< | |||
| > = { | |||
| openai: 'OpenAI', | |||
| anthropic: 'Anthropic', | |||
| gemini: 'Gemini', | |||
| gemini: 'Google gemini', | |||
There was a problem hiding this comment.
I think Gemini and Bedrock should be capitalized.
| acc.push({ | ||
| group: provider, | ||
| label: | ||
| llm.includes(provider) || provider === 'openai' |
There was a problem hiding this comment.
Not clear to me why we would give OpenAI unique treatment.
We should update the size of this select widget so you can see the entire selected value though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update headers
sort llms
simple defaulting for model
Testing
How was this PR tested?