fix(app): improve rendering code preview on large files #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onx2
commented
Dec 18, 2024
onx2
commented
Dec 18, 2024
onx2
commented
Dec 18, 2024
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=3d5fa0945239534f58385c048409067e80d7c725 |
this is probably happpening because of some erroneous react code running that uses prism.highlightAll but who knows
jamie-rasmussen
approved these changes
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR memoizes the code preview component, isolates the scroll to only the preview, and removes highlighting when the file gets large enough. This isn't a perfect solution but at least before the code freeze the page becomes usable.
Testing
Tested on open ai large files >8MB