chore(weave): Eval Compare Perf: Split Query #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=17dff7637deb61678e3d9e85337af63f5b706488 |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=ca24f8095545a13cca441ff420dc8009e4682ede |
tssweeney
commented
Dec 20, 2024
| @@ -50,18 +58,28 @@ export const useEvaluationComparisonState = ( | |||
| const orderedCallIds = useMemo(() => { | |||
| return getCallIdsOrderedForQuery(evaluationCallIds); | |||
| }, [evaluationCallIds]); | |||
| const data = useEvaluationComparisonData(entity, project, orderedCallIds); | |||
| const summaryData = useEvaluationComparisonSummary( | |||
There was a problem hiding this comment.
This is the major change in this PR: splits up the data fetch into 2 stages
tssweeney
changed the title
gtarpenning
reviewed
Jan 2, 2025
| ); | ||
|
|
||
| const flattenedRows = useMemo(() => { | ||
| const rows: FlattenedRow[] = []; | ||
| Object.entries(state.data.resultRows).forEach( | ||
| Object.entries(state.results.result?.resultRows ?? {}).forEach( |
There was a problem hiding this comment.
this is kinda weird, this used to be a real data object but now its a query response?
There was a problem hiding this comment.
like, why are we storing results.result instead of result
There was a problem hiding this comment.
i modified the name to be more clear
gtarpenning
approved these changes
Jan 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance by splitting the eval page loading into two distinct steps