fix(weave_query): propgate tags on mapped run ops during gql key propagation #3386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes WB-21889
Bug description
runs.loggedArtifactVersions
causes a panel crash for users with the error:No ops found for "tag-run" with first arg "TaggedValueType({['project', 'indexCheckpoint']}, artifactVersionType({'id': 'String()'}))"
The
tag-run
op expects an input type that's tagged with therun
, but the tag is missing during compilation.Solution
I added logic to handle propagating tags onto mapped run ops because the existing logic (
should_tag_op_def_outputs
) will only create a TaggedValueType if the opdef's input is aProjectType
or a singularRunType
. In the case of mapped run ops, the inputs will always be aList
ofRunType
s. This specifically happens in run ops that aregql_connection_op.
Other mapped run ops have tags properly propagated because they go through the refinement codepath during compilation.
Testing
Screen.Recording.2025-01-13.at.7.57.01.AM.mov