fix(weave_query): Handle stale file handle os errors on table load #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=20e8e551db3d229b3979aa568f0fbc839c98e8dc |
Comment on lines
+864
to
+865
| if e.errno == errno.ESTALE: | ||
| return None |
There was a problem hiding this comment.
I think we'll want to re-raise the exception if it doesn't fall in this case. Something like:
Suggested change
| if e.errno == errno.ESTALE: | |
| return None | |
| if e.errno == errno.ESTALE: | |
| return None | |
| else: | |
| raise e |
There was a problem hiding this comment.
oh shoot, good catch, thanks @nicholaspun-wandb !
domphan-wandb
force-pushed
the
dom/stale-file-handle-error
branch
from
14ae71e to
ff53a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the panel crash reported in WB-22355
The panel crash happens due to an unhandled 'stale file handle' error when query engine is executing
file-table.See screenshot below from this trace.This panel crash happens very rarely as it took almost a week for repro & trace capture. We're unsure to what causes this, but we're handling the error by returning a None value for the file-table op which is consistent with how we handle pulling files from run summary.
Testing
Using the
invoker.inidev environment.I simulated a stale file handle error by raising an
OSErrorexception witherrno.ESTALEin the opening of the json table and confirmed that the panel on the frontend no longer crashes.