-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui): move objects/ops related pages into folders #3403
Conversation
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=3107d681b458167468583e7b6ad17fb6e3f0c4d9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree there are probably some more optimizations, this is much cleaner than what it was
import {CopyableText} from '../../../../CopyableText'; | ||
import {DocLink} from './common/Links'; | ||
import {isValidVarName} from '../../../../../../../core/util/var'; | ||
import {parseRef} from '../../../../../../../react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these relative imports are starting it get long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah lol
Description
Not perfectly neat, but categorize Op* and Object* pages into folders for repo clarity.
Before:
After:
Testing
👀