Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): move objects/ops related pages into folders #3403

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Jan 14, 2025

Description

Not perfectly neat, but categorize Op* and Object* pages into folders for repo clarity.

Before:
Screenshot 2025-01-14 at 12 01 29 PM

After:
Screenshot 2025-01-15 at 3 28 01 PM

Testing

👀

@gtarpenning gtarpenning marked this pull request as ready for review January 14, 2025 20:00
@gtarpenning gtarpenning requested review from a team as code owners January 14, 2025 20:00
@circle-job-mirror
Copy link

circle-job-mirror bot commented Jan 14, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Copy link
Contributor

@jwlee64 jwlee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree there are probably some more optimizations, this is much cleaner than what it was

import {CopyableText} from '../../../../CopyableText';
import {DocLink} from './common/Links';
import {isValidVarName} from '../../../../../../../core/util/var';
import {parseRef} from '../../../../../../../react';
Copy link
Contributor

@jwlee64 jwlee64 Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these relative imports are starting it get long

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah lol

@gtarpenning gtarpenning merged commit f2dc0e0 into master Jan 16, 2025
123 checks passed
@gtarpenning gtarpenning deleted the griffin/refactor-add-objects-page-path branch January 16, 2025 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants