Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weave): track user on object create #3410

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Jan 14, 2025

Description

https://wandb.atlassian.net/browse/WB-22663

Track user on object create. Also read user id from the db. Basically just a straight rip of how we do it in the calls (and other) tables.

Testing

Updates tests, and adds a specific one.

@circle-job-mirror
Copy link

circle-job-mirror bot commented Jan 14, 2025

@gtarpenning gtarpenning marked this pull request as ready for review January 15, 2025 01:04
@gtarpenning gtarpenning requested a review from a team as a code owner January 15, 2025 01:04
Copy link
Contributor

@jwlee64 jwlee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ALTER TABLE object_versions
ADD COLUMN wb_user_id Nullable(String) DEFAULT NULL;

CREATE OR REPLACE VIEW object_versions_deduped as
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object_versions_deduped is no longer used. In fact it should be dropped

Copy link
Collaborator

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the object_versions_deduped. Also keep in mind that this requires a core change as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants