-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(weave): track user on object create #3410
base: master
Are you sure you want to change the base?
Conversation
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=df111c6bc210d1153a2b4a7d12f6326b4baca4f4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ALTER TABLE object_versions | ||
ADD COLUMN wb_user_id Nullable(String) DEFAULT NULL; | ||
|
||
CREATE OR REPLACE VIEW object_versions_deduped as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
object_versions_deduped is no longer used. In fact it should be dropped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove the object_versions_deduped. Also keep in mind that this requires a core change as well.
Description
https://wandb.atlassian.net/browse/WB-22663
Track user on object create. Also read user id from the db. Basically just a straight rip of how we do it in the calls (and other) tables.
Testing
Updates tests, and adds a specific one.