chore(weave): table row response includes absolute row indices #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bcsherma
force-pushed
the
server-table-row-index
branch
2 times, most recently
from
a1f7dc6 to
e5c77bb
Compare
bcsherma
commented
Feb 5, 2025
| @@ -36,21 +36,22 @@ def make_natural_sort_table_query( | |||
| row_digests_selection = f"arraySlice({row_digests_selection}, 1 + {{{pb.add_param(offset)}: Int64}}, {{{pb.add_param(limit)}: Int64}})" | |||
|
|
|||
| query = f""" | |||
| SELECT DISTINCT tr.digest, tr.val_dump, t.row_order | |||
| SELECT DISTINCT tr.digest, tr.val_dump, t.original_index + {{{pb.add_param(offset or 0)}: Int64}} - 1 as original_index | |||
There was a problem hiding this comment.
Adding the offset here is needed to get the absolute index instead of the index relative to the offset.
bcsherma
force-pushed
the
server-table-row-index
branch
from
e5c77bb to
8ac6e07
Compare
tssweeney
requested changes
Feb 7, 2025
bcsherma
force-pushed
the
server-table-row-index
branch
3 times, most recently
from
907697b to
c3dc8ec
Compare
|
@tssweeney I've updated the exiting suite to test the correctness of the returned indices, which also prompted me to add the index to the response from the sqlite implementation |
tssweeney
approved these changes
Feb 8, 2025
bcsherma
force-pushed
the
server-table-row-index
branch
from
c3dc8ec to
99dbe7b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return absolute index of each row when serving rows from a table. This enables more powerful UIs for editing datasets.