Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(weave): Fix Weave self-managed config #3644

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

flamarion
Copy link
Contributor

@flamarion flamarion commented Feb 10, 2025

Description

  • Fix a missing configuration for Weave config that ensures the correct query type is set.
  • Added tip to fix the config in case the customer wants to use a different ClickHouse cluster name
  • Added a visual confirmation of Weave being successfully enabled

Testing

How was this PR tested?

  • yarn start
  • yarn build

@flamarion flamarion requested review from a team as code owners February 10, 2025 16:13
@flamarion flamarion changed the title chore(docs): Fix Weave self-managed config chore(weave): Fix Weave self-managed config Feb 10, 2025
@flamarion flamarion force-pushed the fix_weave_self_managed_config branch from ce421f5 to dbb693d Compare February 10, 2025 16:14
@circle-job-mirror
Copy link

circle-job-mirror bot commented Feb 10, 2025

@J2-D2-3PO J2-D2-3PO self-requested a review February 10, 2025 16:23
Copy link

@venky-wandb venky-wandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks Flamarion! 🚢

Copy link
Contributor

@J2-D2-3PO J2-D2-3PO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flamarion reviewed the doc changes and pushed language updates in a919434. Also took the the opportunity to improve language and formatting across the doc. Please take a look just to make sure I didn't mess up any of your technical info

Also, in 6709253, I fixed that failing Python lint test. Just a heads up that, if you add media like a .png, you have to run nox -e lint locally at the root level of the weave repo to pre-lint the PR for issues that will be flagged by the GH checks. If that command returns any failures, just run it again and it will usually auto fix the issue. You can then push and the linter checks should pass. That being said, if you run into issues in the future, tag me or someone from the Weave eng team and we can help

@J2-D2-3PO J2-D2-3PO self-requested a review February 10, 2025 22:28
@J2-D2-3PO J2-D2-3PO requested a review from tssweeney February 10, 2025 22:29
@J2-D2-3PO J2-D2-3PO changed the title chore(weave): Fix Weave self-managed config docs(weave): Fix Weave self-managed config Feb 10, 2025
@J2-D2-3PO J2-D2-3PO merged commit 733eb8f into master Feb 10, 2025
133 checks passed
@J2-D2-3PO J2-D2-3PO deleted the fix_weave_self_managed_config branch February 10, 2025 22:31
@J2-D2-3PO J2-D2-3PO removed the request for review from tssweeney February 10, 2025 22:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants