-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(weave): Fix Weave self-managed config #3644
Conversation
ce421f5
to
dbb693d
Compare
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=4613adbf487cbb11ffb186f317b5f5c57e534e3b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, thanks Flamarion! 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flamarion reviewed the doc changes and pushed language updates in a919434. Also took the the opportunity to improve language and formatting across the doc. Please take a look just to make sure I didn't mess up any of your technical info
Also, in 6709253, I fixed that failing Python lint test. Just a heads up that, if you add media like a .png
, you have to run nox -e lint
locally at the root level of the weave repo to pre-lint the PR for issues that will be flagged by the GH checks. If that command returns any failures, just run it again and it will usually auto fix the issue. You can then push and the linter checks should pass. That being said, if you run into issues in the future, tag me or someone from the Weave eng team and we can help
Description
Testing
How was this PR tested?
yarn start
yarn build