[pull] master from ruby:master #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
If anything, I think this may be causing some false positives.
Most of the stuff is not actually necessary.
The name "gem" could be confused with RubyGems activation method.
Currently evenn if the require actually fails, they suggest that the file was actually loaded, which is confusing. I reworded them to reduce this confusion.
Since not every dependency gets referenced. When resolving from scratch a Gemfile including only `"gem "rails", "~> 8.0.1"`, I get the following results: ### Before Total allocated: 295.01 MB (3624335 objects) Total retained: 119.31 MB (1364474 objects) ### After Total allocated: 288.21 MB (3498515 objects) Total retained: 119.10 MB (1357976 objects) rubygems/rubygems@61eee39d81 Co-authored-by: Samuel Giddins <[email protected]>
When resolving from scratch a Gemfile including only `"gem "rails", "~> 8.0.1"`, I get the following results: ### Before Total allocated: 288.21 MB (3498515 objects) Total retained: 119.10 MB (1357976 objects) ### After Total allocated: 277.44 MB (3383182 objects) Total retained: 117.55 MB (1338622 objects) rubygems/rubygems@2d3d6e5015
Sometimes we'll resolve using bare `Gem::Dependency` instances rather than `Bundler::Dependency` instances, which is fine, simpler, and saves some memory. When resolving from scratch a Gemfile including only `"gem "rails", "~> 8.0.1"`, I get the following results: ### Before Total allocated: 277.48 MB (3384318 objects) Total retained: 117.53 MB (1338657 objects) ### After Total allocated: 265.06 MB (3186053 objects) Total retained: 116.98 MB (1302280 objects) rubygems/rubygems@c6dc2966c5
…stances They use less memory that way. When resolving from scratch a Gemfile including only `"gem "rails", "~> 8.0.1"`, I get the following results: ### Before Total allocated: 265.06 MB (3186053 objects) Total retained: 116.98 MB (1302280 objects) ### After Total allocated: 262.99 MB (3177437 objects) Total retained: 115.91 MB (1297821 objects) rubygems/rubygems@a4ef9c5f56
…ding dependencies For installed specifications, we can ignore any constraints they may have, since we know they match the current version of Ruby or otherwise would not be installed. For remote specifications, we already resolve optimistically without metadata and retry force-fetching it if necessary. If in the future we support resolving against a Ruby version different that the one being run, we'll probably need to change this but now it's unnecessary and saves some memory. ### Before Total allocated: 262.99 MB (3177437 objects) Total retained: 115.91 MB (1297821 objects) ### After Total allocated: 259.89 MB (3134199 objects) Total retained: 115.05 MB (1283779 objects) rubygems/rubygems@201c1863fc
…sing The previous wording was too specific, there may be situations when the gem has actually never installed (so never deleted either). rubygems/rubygems@e4a0d71fbe
I think we need this to silence the following warning when running `bin/console` with Ruby 3.4 ``` ./bin/console:10: warning: irb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add irb to your Gemfile or gemspec to silence this warning. ``` rubygems/rubygems@c46230c856
Co-authored-by: Jean Boussier <[email protected]>
Co-authored-by: Jean Boussier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )