Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-saving with the Patch Manager causes "P" hooks to continually get longer #256

Closed
Spleeeeen opened this issue Sep 2, 2020 · 1 comment · Fixed by #262
Closed

Re-saving with the Patch Manager causes "P" hooks to continually get longer #256

Spleeeeen opened this issue Sep 2, 2020 · 1 comment · Fixed by #262
Assignees
Labels
bug Something isn't working correctly

Comments

@Spleeeeen
Copy link

  • Open a ROM
  • Open the Patch Manager
  • Press the "Add" button
  • Press Browse and select a C patch file* which includes the "P" signifier in the Hook
  • Press OK, then Save
  • Open the Patch Manager again. The Hook is now (correctly) 4 bytes longer. If you press Edit, you can see that it comes after the "P".
  • Save the Patch Manager, then Open it again. Notice that the Hook is 4 bytes longer.
  • Repeat the previous step any number of times; the Hook will continue to grow.

*Here is an example of a file which will generate the problem: https://hatebin.com/cbbiomfryi

@shinespeciall shinespeciall added the bug Something isn't working correctly label Sep 2, 2020
@Goldensunboy Goldensunboy self-assigned this Sep 2, 2020
@Goldensunboy
Copy link
Collaborator

Reproduced. The hook string shown in the manager is actually not supposed to display the address from the P identifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants