Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing tileset from other rom will cause problem when opening Room Config Dialog #402

Closed
becored opened this issue Jul 29, 2022 · 1 comment · Fixed by #403
Closed
Labels
bug Something isn't working correctly ui The issue related to the user interface.

Comments

@becored
Copy link

becored commented Jul 29, 2022

Repro:

  • Open a vanilla rom
  • File > Import from ROM > Import Tileset
  • Select a vanilla rom
  • Input "50" and click OK
  • Edit > Room Config
  • Error: Unknown BG tile data pointer!
@shinespeciall
Copy link
Member

oh, that's some problem in the UI logic.
after the implementation of Graphic Manager, we can change background tiles in Tilesets. since the backgroud data are managed by the manager, we cannot import them when import Tileset from another ROM. so i let the editor use a default bg tile data pointer to deal with this problem.
but that will cause some problem in the Room Config Dialog that, it cannot recognize default bg tile data by refering the bg tile data used by the vanilla Tileset of the current global id, and it also cannot find any graphic entry exist in the ROM managed by the Graphic Manager, so it shows the Error Dialog. your ROM didn't get corrupted, it is some UI logic problems.
i can changed the UI logic, and let it check every vanilla bg tile data, and see if any of them match the pointer, then there will be no problem managing Layer 3 mapping data in the Room Config Dialog. you can even do something like, let Tileset 0x01 use the bg tile data from Tileset 0x02, then import the Tileset into another ROM. the Room Config Dialog should still work in the new UI logic.

@shinespeciall shinespeciall added bug Something isn't working correctly ui The issue related to the user interface. labels Jul 29, 2022
shinespeciall added a commit that referenced this issue Jul 29, 2022
@shinespeciall shinespeciall changed the title Importing tileset from other rom corrupts the BG data importing tileset from other rom will cause problem when opening Room Config Dialog Jul 29, 2022
shinespeciall added a commit that referenced this issue Jul 31, 2022
* add the level components class

* a lot of work for animated Tile8x8 Editor

add animated Tile group editor UI class
tweak TIleset and AnimatedTile8x8Group classes to let them work together
add AnimatedTile8x8Group singletons into the ROMUtils namespace

* now all the animated tile groups can be shown in the editor

* add some basic code to the operation struct

* fix a bug in delete global operation , add WIP operation code for the new editor

* add more missing logic into the Operation and SaveLevel functions

* all the UI logic is done

* the save logic works

* change dialog title

* Add Info Textbox for animated tile group editor

* Fix #402

* some tweaks and fixes in Sprites Editor to make the OAM designer more stable

* 2 small fixes on C code generation

* add a missing 0x prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly ui The issue related to the user interface.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants