Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why most operations didn't work with the devtools window open. It's because of these lines. I'm certain that the command
webContents.getAllWebContents()
includes devtools window. I managed to debug that far and see an array of two elements returned, but I couldn't see a way to distinguish them.Also the electronJS documentation says:
On line 11 you get the
focusedWindow
directly. Can we do the same for the remaining lines?I'm not sure if you wanted to standardise on
BrowserWindow.getFocusedWindow()?.webContents
vswebContents.getFocusedWebContents()
. They look equivalent to me.