Add CmdOrCtrl+Shift+W shortcut to close log file #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, this is just a poor-man's workaround. What I really wanted was to simply drag-n-drop over an existing log, and open a new file. But I'm not familiar enough with Angular or the dropzone library, and this was a quicker fix. |
|
Code change looks fine to add this new keyboard shortcut |
|
Looks good to me, thanks @ianleeder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm often switching between mutliple log files, and wanted a more convenient way to do so. That's the original reason I downloaded the source code!
Many apps accept
Ctrl-Wto close the current document. That's already in use to close the window, so I addedCtrl-Shift-W.