Add support for multiple levels of nesting, and fix empty values #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if value is undefined, instead of just false
|
Code change looks good to me @EBD232 |
|
Great! There is a nesting.txt attached in the original message above that I used for testing. The .json extension was not allowed as an attached file |
|
Will look at this later tonight or tomorrow. Kid/family stuff now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for multiple levels of nesting, using recursion. I have attached a sample file, that is shown in the screenshot.
I'm not sure if this totally fixes #13, but it seems to work fine for me.
Also fixes #705
nesting.txt