-
Notifications
You must be signed in to change notification settings - Fork 273
Now We can Use Header File . #365
base: master
Are you sure you want to change the base?
Conversation
This looks really good, I'll review in a moment. |
d40c8cc
to
1897ebb
Compare
So can we also compile multiple c/cpp files if this is merged ? |
@iFlameing after looking into it, it seems like we are just handling a specific case of a single header file. Its a great start, I was hoping if we can come up with some more generic solution for this, so that we can compile as many header files as we want. |
@AnshulMalik The main problem regarding the multiple file is that, we have to mention the file name into the build.ts file manually. |
Can we extract all the includes somehow from the one source file we are compiling. |
@AnshulMalik This might be possible but for compiling we have to send all the file to server and if we include single file in main.c and import other file into header.h then we also have to send all the file which we are importing into the header.h . |
So it's recursive then, don't you love recursion? :P |
Now it is supporting multiple header file . @AnshulMalik What you say. |
@yurydelendik I made the change from service.compilefile to service.compilefiles it outputting the file "main.wasm" but when I run it , It giving me [error]: "CompileError: wasm validation error: at offset 4: failed to match magic number". |
Associated Issue: #298
Here's the contributing guide at https://github.com/wasdk/WebAssemblyStudio/wiki/Contributing
Summary of Changes
I changes the service.ts, compilerservice.ts and clangservice.ts according to need.
I made some modification in build.ts and in the template also for simple implementation of the header file.
Test Plan
Due to some change in the service.ts and specially in clangservice.ts some testcase fail.
But I check the implementation of header file by manually checking .
Example test plan:
Screenshots/Videos (OPTIONAL)