Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support call aliases in a manifest file #199

Closed
autodidaddict opened this issue May 19, 2021 · 3 comments
Closed

Support call aliases in a manifest file #199

autodidaddict opened this issue May 19, 2021 · 3 comments
Labels
good first issue Good for newcomers RFC

Comments

@autodidaddict
Copy link
Member

We would like to make it easier to write manifest files so that we aren't constantly filling the file with the cumbersome actor public keys. Instead, we would like to be able to use the string that is associated with the actor's call alias (which can be set and displayed using the wash command line).

Of course, the trick is in figuring out where to go get the actor from once you have its call alias. You won't know the call alias for the actor until you load the actor module itself.

Would love to hear additional commentary on this feature, alternatives, etc.

@autodidaddict autodidaddict added good first issue Good for newcomers RFC labels May 19, 2021
@stevelr
Copy link
Contributor

stevelr commented May 19, 2021

  • I like the idea of, at minimum, declaring an actor or provider as a yaml object with fields for file path/oci reference, and any aliases. so that you can refer to the alias in other places in the file.

  • I found the makefile hack, using a wash command to inspect the claims and setting an environment variable before the wasmcloud command, to be cumbersome and not entirely reliable.

@stevelr
Copy link
Contributor

stevelr commented May 19, 2021

  • if manifest alias and call alias are different things, there needs to be a clear distinction. If we could make them the same thing, it would reduce confusion. I don't know if there is really a need to have two separate kinds of aliases.

@stevelr
Copy link
Contributor

stevelr commented May 19, 2021

  • certainly we need to be able to specify public keys in the manifest to be precise.
  • however, during development, it would be great if we didn't have to specify keys at all. The first stage manifest interpreter could call the OCI registry or load the file to get the claims and determine the public keys. The response/data could be cached for faster response next time. that would need a --no-cache flag, or a separate clear-cache command if keys are changed.

rvolosatovs pushed a commit to rvolosatovs/wasmCloud that referenced this issue Mar 21, 2023
* accept uppercase URL parameter, correct default connect

Signed-off-by: Brooks Townsend <[email protected]>

* allow case insensitive links

Signed-off-by: Brooks Townsend <[email protected]>

* allow case insensitive linkdef URL parameter

Signed-off-by: Brooks Townsend <[email protected]>

Signed-off-by: Brooks Townsend <[email protected]>
connorsmith256 pushed a commit to connorsmith256/wasmCloud that referenced this issue Oct 17, 2023
* Add Id const generic type, and HostId

Signed-off-by: Stuart Harris <[email protected]>

* ServerId, ServiceId, ModuleId

Signed-off-by: Stuart Harris <[email protected]>

* tiny refactor

Signed-off-by: Stuart Harris <[email protected]>
connorsmith256 pushed a commit to connorsmith256/wasmCloud that referenced this issue Oct 17, 2023
* Add Id const generic type, and HostId

Signed-off-by: Stuart Harris <[email protected]>

* ServerId, ServiceId, ModuleId

Signed-off-by: Stuart Harris <[email protected]>

* tiny refactor

Signed-off-by: Stuart Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers RFC
Projects
None yet
Development

No branches or pull requests

3 participants