Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add some initial deny for unused_imports and unused_variables
Browse files Browse the repository at this point in the history
Additional unused variable fix on unix

Remove unused import on unix

Remove unused windows import
bjfish committed May 11, 2019
1 parent fa54025 commit 5197d52
Showing 19 changed files with 28 additions and 7 deletions.
2 changes: 2 additions & 0 deletions lib/clif-backend/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(unused_imports, unused_variables)]

mod cache;
mod func_env;
mod libcalls;
2 changes: 2 additions & 0 deletions lib/emscripten/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(unused_imports, unused_variables)]

#[macro_use]
extern crate wasmer_runtime_core;

1 change: 0 additions & 1 deletion lib/emscripten/src/syscalls/unix.rs
Original file line number Diff line number Diff line change
@@ -53,7 +53,6 @@ use libc::{
sendto,
setpgid,
setsockopt,
size_t,
sockaddr,
socket,
socklen_t,
1 change: 1 addition & 0 deletions lib/llvm-backend/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![cfg_attr(nightly, feature(unwind_attributes))]

mod backend;
2 changes: 1 addition & 1 deletion lib/llvm-backend/src/platform/unix.rs
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ pub unsafe fn visit_fde(addr: *mut u8, size: usize, visitor: extern "C" fn(*mut
}

#[cfg(not(target_os = "macos"))]
pub unsafe fn visit_fde(addr: *mut u8, size: usize, visitor: extern "C" fn(*mut u8)) {
pub unsafe fn visit_fde(addr: *mut u8, _size: usize, visitor: extern "C" fn(*mut u8)) {
visitor(addr);
}

2 changes: 1 addition & 1 deletion lib/middleware-common/src/call_trace.rs
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ impl FunctionMiddleware for CallTrace {
fn feed_event<'a, 'b: 'a>(
&mut self,
op: Event<'a, 'b>,
module_info: &ModuleInfo,
_module_info: &ModuleInfo,
sink: &mut EventSink<'a, 'b>,
) -> Result<(), Self::Error> {
match op {
2 changes: 2 additions & 0 deletions lib/middleware-common/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
#![deny(unused_imports, unused_variables)]

pub mod call_trace;
2 changes: 2 additions & 0 deletions lib/runtime-abi/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(unused_imports, unused_variables)]

#[cfg(not(target_os = "windows"))]
#[macro_use]
extern crate failure;
2 changes: 2 additions & 0 deletions lib/runtime-c-api/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(unused_imports, unused_variables)]

extern crate wasmer_runtime;
extern crate wasmer_runtime_core;

2 changes: 1 addition & 1 deletion lib/runtime-core/src/codegen.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::{
backend::RunnableModule,
backend::{sys::Memory, Backend, CacheGen, Compiler, CompilerConfig, Token},
backend::{Backend, CacheGen, Compiler, CompilerConfig, Token},
cache::{Artifact, Error as CacheError},
error::{CompileError, CompileResult},
module::{ModuleInfo, ModuleInner},
1 change: 1 addition & 0 deletions lib/runtime-core/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![cfg_attr(nightly, feature(unwind_attributes))]

#[cfg(test)]
2 changes: 2 additions & 0 deletions lib/runtime/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(unused_imports, unused_variables)]

//! Wasmer-runtime is a library that makes embedding WebAssembly
//! in your application easy, efficient, and safe.
//!
4 changes: 2 additions & 2 deletions lib/singlepass-backend/src/codegen_x64.rs
Original file line number Diff line number Diff line change
@@ -478,7 +478,7 @@ impl ModuleCodeGenerator<X64FunctionCode, X64ExecutionContext, CodegenError>
Ok(())
}

unsafe fn from_cache(artifact: Artifact, _: Token) -> Result<ModuleInner, CacheError> {
unsafe fn from_cache(_artifact: Artifact, _: Token) -> Result<ModuleInner, CacheError> {
Err(CacheError::Unknown(
"the singlepass compiler API doesn't support caching yet".to_string(),
))
@@ -1409,7 +1409,7 @@ impl FunctionCodeGenerator<CodegenError> for X64FunctionCode {
Ok(())
}

fn begin_body(&mut self, module_info: &ModuleInfo) -> Result<(), CodegenError> {
fn begin_body(&mut self, _module_info: &ModuleInfo) -> Result<(), CodegenError> {
let a = self.assembler.as_mut().unwrap();
a.emit_push(Size::S64, Location::GPR(GPR::RBP));
a.emit_mov(Size::S64, Location::GPR(GPR::RSP), Location::GPR(GPR::RBP));
1 change: 1 addition & 0 deletions lib/singlepass-backend/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![deny(unused_imports, unused_variables)]
#![feature(proc_macro_hygiene)]

#[cfg(not(any(
2 changes: 2 additions & 0 deletions lib/wasi/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(unused_imports, unused_variables)]

#[macro_use]
extern crate log;

1 change: 0 additions & 1 deletion lib/win-exception-handler/src/exception_handling.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use std::ffi::c_void;
use std::ptr::NonNull;
use wasmer_runtime_core::vm::{Ctx, Func};

2 changes: 2 additions & 0 deletions lib/win-exception-handler/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(unused_imports, unused_variables)]

#[cfg(windows)]
mod exception_handling;

2 changes: 2 additions & 0 deletions src/bin/wasmer.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(unused_imports, unused_variables)]

extern crate structopt;

use std::env;
2 changes: 2 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(unused_imports, unused_variables)]

#[macro_use]
extern crate wasmer_runtime_core;
// extern crate wasmer_emscripten;

0 comments on commit 5197d52

Please sign in to comment.