Skip to content

Commit

Permalink
Merge #2976
Browse files Browse the repository at this point in the history
2976: Upgrade enumset minimum version to one that compiles r=epilys a=palfrey

# Description

enumset dependency was on 1.0, but only [1.0.2 has a fix for compiling with newer syn](https://github.com/Lymia/enumset/blob/master/RELEASES.md#version-102-2021-01-25). This PR fixes that, and adds a makefile target for testing the minimal version scenario. It probably really should be added to the CI, but not sure where in the complicated setup here!

# Review

- [x] Add a short description of the change to the CHANGELOG.md file


Co-authored-by: Tom Parker-Shemilt <[email protected]>
  • Loading branch information
bors[bot] and palfrey authored Jun 29, 2022
2 parents a2d1c9e + 34aafad commit 711bfef
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@ Looking for changes that affect our C API? See the [C API Changelog](lib/c-api/C
## **Unreleased**

### Changed
- #2946 Remove dylib,staticlib engines in favor of a single Universal engine
- [#2946](https://github.com/wasmerio/wasmer/pull/2946) Remove dylib,staticlib engines in favor of a single Universal engine
- [#2949](https://github.com/wasmerio/wasmer/pull/2949) Switch back to using custom LLVM builds on CI

### Fixed
- [#2963](https://github.com/wasmerio/wasmer/pull/2963) Remove accidental dependency on libwayland and libxcb in ClI
- [#2942](https://github.com/wasmerio/wasmer/pull/2942) Fix clippy lints.
- [#2943](https://github.com/wasmerio/wasmer/pull/2943) Fix build error on some archs by using c_char instead of i8
- [2976](https://github.com/wasmerio/wasmer/pull/2976) Upgrade minimum enumset to one that compiles

## 2.3.0 - 2022/06/06

Expand Down
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -704,3 +704,7 @@ lint: lint-formatting lint-packages

install-local: package
tar -C ~/.wasmer -zxvf wasmer.tar.gz

test-minimal-versions:
rm -f Cargo.lock
cargo +nightly build --tests -Z minimal-versions --all-features
2 changes: 1 addition & 1 deletion lib/c-api/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ wasmer-compiler = { version = "=2.3.0", path = "../compiler" }
wasmer-middlewares = { version = "=2.3.0", path = "../middlewares", optional = true }
wasmer-wasi = { version = "=2.3.0", path = "../wasi", default-features = false, features = ["host-fs", "sys"], optional = true }
wasmer-types = { version = "=2.3.0", path = "../types" }
enumset = "1.0"
enumset = "1.0.2"
cfg-if = "1.0"
lazy_static = "1.4"
libc = { version = "^0.2", default-features = false }
Expand Down
2 changes: 1 addition & 1 deletion lib/compiler/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ edition = "2018"
wasmer-types = { path = "../types", version = "=2.3.0", default-features = false }
wasmparser = { version = "0.83", optional = true, default-features = false }
target-lexicon = { version = "0.12.2", default-features = false }
enumset = "1.0"
enumset = "1.0.2"
hashbrown = { version = "0.11", optional = true }
serde = { version = "1.0", features = ["derive"], optional = true }
thiserror = "1.0"
Expand Down

0 comments on commit 711bfef

Please sign in to comment.